Finalize v1.1.0 release blockers: manifest, receipts, examples, spec, docs, checksums#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
reasonrequired only forfailedoutcomes where applicable) so conformance tooling and downstream integrators have an unambiguous surface.Description
manifest.jsonstatusto a single definitive valuecurrentand updated validation to enforce that posture by changing the manifest assertion inscripts/validate-all.mjs.merchantinschemas/v1.1.0/commercial/authorize/authorize.receipt.schema.jsonto restore actor symmetry with request contracts.schemas/v1.1.0/commercial/checkout/checkout.receipt.schema.jsonandschemas/v1.1.0/commercial/purchase/purchase.receipt.schema.jsonsoreasonis required forfailedonly and no longer required forpending.examples/v1.1.0/commercial/verify/invalid/900-verify.receipt.invalid.jsonexplicitly and intentionally invalid (updatedreceipt_idandbasis) so the invalid set contains only true negatives.payment_inputto the commercial payment grammar inSPEC.mdso the spec matches the current schema surface.CHANGELOG.mdand finalizereleases/v1.1.0.mdwith concrete Added/Changed/Removed notes, and remove unfinished draft language fromSECURITY_PROVENANCE.mdwhile still accurately stating the repository-validated, not-yet-published posture.checksums.txtto reflect the updated artifacts.Finalize v1.1.0 release blockers).Testing
npm installwhich completed successfully.npm run generate:checksumswhich wrote updatedchecksums.txtsuccessfully.verifyreceipt schema using an Ajv2020 check, which correctly reported the fixture as invalid.npm run validate(which runsvalidate:schemas,validate:examples,validate:integrity, andvalidate:pack) and the suite completed successfully after the fixes.Codex Task